feat: Add Iceberg partition name generation utility #15443

PingLiuPing · 2025-11-07T22:03:45Z

Add Iceberg partition path utility for partition path naming.
Introduces IcebergPartitionPath, a utility class that converts partition keys to
their string representations for use in Iceberg partition directory paths.
The implementation follows the behavior of the Apache Iceberg Java library.

netlify · 2025-11-07T22:03:51Z

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	`2dee873`
🔍 Latest deploy log	https://app.netlify.com/projects/meta-velox/deploys/690fb485febddc0008c9ef93

mbasmanova · 2025-11-08T10:57:28Z

velox/connectors/hive/iceberg/IcebergPartitionPath.h

+  std::string toPartitionString(int32_t value, const TypePtr& type)
+      const override;
+
+  /// Converts a Timestamp partition key to its string representation.


Converts a Timestamp partition key to its string representation.

This sentence is redundant. Consider dropping.

mbasmanova · 2025-11-08T10:58:31Z

velox/connectors/hive/iceberg/IcebergPartitionPath.cpp

+
+namespace facebook::velox::connector::hive::iceberg {
+
+constexpr int32_t kEpochYear = 1970;


move this into the only function where it is used.

mbasmanova · 2025-11-08T10:58:50Z

velox/connectors/hive/iceberg/IcebergPartitionPath.cpp

+      if (type->isDate()) {
+        return DATE()->toString(value);
+      }
+      return folly::to<std::string>(value);


nit: fmt::to_string

mbasmanova · 2025-11-08T11:00:10Z

velox/connectors/hive/iceberg/IcebergPartitionPath.cpp

+  }
+}
+
+std::string IcebergPartitionPath::toPartitionString(


perhaps, add a check for transform type. I assume it must be kIdentity.

Yes, you are right

mbasmanova · 2025-11-08T11:02:41Z

velox/connectors/hive/iceberg/tests/IcebergPartitionPathTest.cpp

+  EXPECT_EQ(
+      test(
+          TransformType::kIdentity,
+          StringView("\x48\x65\x6c\x6c\x6f"),


consider adding helper method testVarbinary that takes a single std::string argument. This will make code shorter and easier to read and allow testing long strings.

Thank you for the suggestion.

mbasmanova · 2025-11-08T11:03:19Z

velox/connectors/hive/iceberg/tests/IcebergPartitionPathTest.cpp

+
+TEST(IcebergPartitionPathTest, identityTimestamp) {
+  EXPECT_EQ(
+      test(TransformType::kIdentity, Timestamp(0, 0), TIMESTAMP()),


add testTimestamp helper method that takes a single Timestamp argument

mbasmanova · 2025-11-08T11:05:06Z

velox/connectors/hive/iceberg/tests/IcebergPartitionPathTest.cpp

+
+TEST(IcebergPartitionPathTest, truncateString) {
+  EXPECT_EQ(
+      test(TransformType::kTruncate, StringView("abc"), VARCHAR()), "abc");


I assume tranform type doesn't matter here. The results would be the same for kIdentity and kTruncate. If so, consider adding a helper method testString(std::string) which converts string using kIdentity and kTruncate, assert that results are the same and returns that result.

Thanks.
I added a helper function testString.

mbasmanova · 2025-11-08T11:05:56Z

velox/connectors/hive/iceberg/tests/IcebergPartitionPathTest.cpp

+namespace {
+
+template <typename T>
+std::string test(TransformType transform, T value, const TypePtr& type) {


Since we are not testing anything here, let's rename to something like toPath.

mbasmanova · 2025-11-10T10:52:30Z

velox/connectors/hive/iceberg/IcebergPartitionPath.cpp

+  return value.toString(options);
+}
+
+std::string IcebergPartitionPath::toPartitionString(


perhaps, add a check for transformType here as well

@mbasmanova Sorry I missed this comment. Will fix this in next PR.

mbasmanova · 2025-11-10T10:54:29Z

velox/connectors/hive/iceberg/tests/IcebergPartitionPathTest.cpp

+}
+
+std::string testInteger(int32_t value) {
+  auto identity = toPath(TransformType::kIdentity, value, INTEGER());


consistency: identity vs. identityResult, trunc vs. truncateResult

please, unify

Sorry I missed this comment. Will fix this in next PR.

mbasmanova

Thanks.

PingLiuPing · 2025-11-10T17:34:01Z

@peterenescu Could you please help to import this PR? Thank you.

meta-codesync · 2025-11-10T18:22:00Z

@peterenescu has imported this pull request. If you are a Meta employee, you can view this in D86686298.

meta-codesync · 2025-11-10T22:54:37Z

@peterenescu merged this pull request in 51d4a94.

…incubator#15443)" This reverts commit 51d4a94.

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

…incubator#15443)" This reverts commit 51d4a94.

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

…incubator#15443)" This reverts commit 51d4a94.

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

…incubator#15443)" This reverts commit 51d4a94.

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a

PingLiuPing requested a review from majetideepak as a code owner November 7, 2025 22:03

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2025

PingLiuPing requested a review from mbasmanova November 7, 2025 22:03

mbasmanova reviewed Nov 8, 2025

View reviewed changes

Add Iceberg partition path utility

2dee873

PingLiuPing force-pushed the lp_iceberg_partition_path branch from 219ec2a to 2dee873 Compare November 8, 2025 21:22

mbasmanova reviewed Nov 10, 2025

View reviewed changes

mbasmanova approved these changes Nov 10, 2025

View reviewed changes

mbasmanova added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 10, 2025

meta-codesync bot closed this in 51d4a94 Nov 10, 2025

facebook-github-bot added the Merged label Nov 10, 2025

PingLiuPing added a commit to IBM/velox that referenced this pull request Nov 11, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

26324ec

…incubator#15443)" This reverts commit 51d4a94.

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 11, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

0ec09f9

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 11, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

f5c94fb

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 11, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

d85ddf7

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 12, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

f87e785

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 12, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

0f60c97

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

PingLiuPing added a commit to IBM/velox that referenced this pull request Nov 12, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

20dee14

…incubator#15443)" This reverts commit 51d4a94.

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 12, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

99c152a

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 854) Iceberg staging hub commit 1/14 - 26324ec

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 12, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

1148813

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 13, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

0b5988e

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 13, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

facb41b

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 13, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

2ebd417

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 13, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

3368b89

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 14, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

c9ae768

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 860) Iceberg staging hub commit 1/13 - 20dee14

PingLiuPing added a commit to IBM/velox that referenced this pull request Nov 14, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

7a462c0

…incubator#15443)" This reverts commit 51d4a94.

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 14, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

cb0028d

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 14, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

4bfeb09

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 14, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

244b656

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 16, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

7694c6b

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 16, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

d5b199c

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

FelixYBW pushed a commit to IBM/velox that referenced this pull request Nov 16, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

39f5370

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 16, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

a25a4df

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 16, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

da9ecbe

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 864) Iceberg staging hub commit 2/14 - 7a462c0

PingLiuPing added a commit to IBM/velox that referenced this pull request Nov 17, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

112ce8a

…incubator#15443)" This reverts commit 51d4a94.

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 17, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

7cf61d5

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 17, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

ae74a83

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 17, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

b6ecc0b

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 18, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

702ba45

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 18, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

95e8904

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a

prestodb-ci pushed a commit to IBM/velox that referenced this pull request Nov 18, 2025

Revert "feat: Add Iceberg partition name generation utility (facebook…

fe89a15

…incubator#15443)" This reverts commit 51d4a94. Alchemy-item: (ID = 885) Iceberg staging hub commit 3/15 - 112ce8a


		namespace facebook::velox::connector::hive::iceberg {

		constexpr int32_t kEpochYear = 1970;

feat: Add Iceberg partition name generation utility #15443

feat: Add Iceberg partition name generation utility #15443

Uh oh!

Conversation

PingLiuPing commented Nov 7, 2025

Uh oh!

netlify bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for meta-velox canceled.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbasmanova left a comment

Choose a reason for hiding this comment

Uh oh!

PingLiuPing commented Nov 10, 2025

Uh oh!

meta-codesync bot commented Nov 10, 2025

Uh oh!

meta-codesync bot commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Nov 7, 2025 •

edited

Loading